Skip to content

Conversation

@mchoo7
Copy link
Contributor

@mchoo7 mchoo7 commented Nov 5, 2025

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 5, 2025

CodSpeed Performance Report

Merging #2030 will not alter performance

Comparing mchoo7:fix/gitignore (e1f015d) with master (abf29f2)

Summary

✅ 3 untouched

@dalance
Copy link
Collaborator

dalance commented Nov 5, 2025

The /target entry in gitignore of this repo come from cargo new of Rust.
I investigated the reason why trailing slash doesn't exist and found the following PR.

rust-lang/cargo#4944

So I think it is better that the trailing slashes of /target/ and /dependencies/ are removed.
This is because these path may be symlink created by users.
I'm sorry again, but could you remove them?

@mchoo7
Copy link
Contributor Author

mchoo7 commented Nov 6, 2025

The /target entry in gitignore of this repo come from cargo new of Rust. I investigated the reason why trailing slash doesn't exist and found the following PR.

rust-lang/cargo#4944

So I think it is better that the trailing slashes of /target/ and /dependencies/ are removed. This is because these path may be symlink created by users. I'm sorry again, but could you remove them?

Fixed!

Same for /obj_dir/ (generated by verilator)?

@dalance
Copy link
Collaborator

dalance commented Nov 6, 2025

Same for /obj_dir/ (generated by verilator)?

I feel either is fine because tool generated paths are probably real directory.

@dalance
Copy link
Collaborator

dalance commented Nov 6, 2025

I think this PR is ready to merge.
I'll merge after passing CI.
Thank you for your contribution!

@dalance dalance merged commit 0aaa901 into veryl-lang:master Nov 6, 2025
14 checks passed
@dalance dalance added the enhancement New feature or request label Nov 6, 2025
@dalance dalance added this to the v0.17.1 milestone Nov 6, 2025
@mchoo7 mchoo7 deleted the fix/gitignore branch November 6, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants