Use url.parse to parse the given host - IP6 support #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the meaning of the proxy(`host`, ...) param slightly..
* a protocol is now required (url.parse needs it), thus https detection depends solely on the protocol
* port 443 no longer implies https
* an Error is `next`ed otherwise
* ipv6 addresses with port are now supported ([::1]:1234 would fail to split before)
Also removed unused `type-is`, and added `lodash.iserror`
|
This may depend on nodejs/node#5308 for actual IPv6 address support. |
|
merged by command line, and add support for simple url like httpbin.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the meaning of the proxy(
host, ...) param slightly..nexted otherwiseAlso removed unused
type-is, and addedlodash.iserror