Fix performance issue with deep nesting #81
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance issue in #71 is due to the layout cache being constantly invalidated.
It is solved by having a separate cache for the recursive call in section "3. Determine the flex base size and hypothetical main size of each item"
This fix makes one test fail (but it makes sense, each cache measure once):
Running the example code from #71 in debug mode gives:
and in release:
The exponential behaviour is clearly gone, and the measured time saturates since most caches from the previous iterations are reused.