-
Couldn't load subscription status.
- Fork 100
Add python 3.13 support to CMakeLists.txt #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This matches the work done in vllm-project@8878692 Python 3.8 was subsequently dropped as well here. Signed-off-by: Thibault Schueller <[email protected]>
|
Could you please take a look @LucasWilkinson @WoosukKwon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just for dev or is this a python version bump of the whole project? If it's the latter we would need to change PYTHON_VERSION in the dockerfiles as well as the CI config files to make sure all deps are ok.
To the best of my knowledge python3.13 is already covered by the CI: https://github.com/vllm-project/flash-attention/blob/main/.github/workflows/publish.yml#L46 |
LGTM, but ill let the CI experts have the final word |
|
@NickLucche I think your requested review changes is preventing this PR to be merged |
|
@WoosukKwon can you please merge? I do not have permission |
This matches the work done in 8878692 Python 3.8 was subsequently dropped as well here.
Related to vllm-project/vllm#13164