Skip to content

Conversation

@mickaelseznec
Copy link

No description provided.

@mickaelseznec mickaelseznec force-pushed the mseznec/add-fp8-kernel-compilation branch from e11ba83 to db8c667 Compare February 19, 2025 12:40
@LucasWilkinson
Copy link
Collaborator

Thanks for the PR, I will try to test this soon!

Signed-off-by: Mickael Seznec <[email protected]>
Signed-off-by: Mickael Seznec <[email protected]>
Signed-off-by: Mickael Seznec <[email protected]>
@mickaelseznec mickaelseznec force-pushed the mseznec/add-fp8-kernel-compilation branch from b6ca541 to 375edf5 Compare February 25, 2025 16:40
@LucasWilkinson
Copy link
Collaborator

Apologies for the very long delay! the 12.1 build issues is now landed on main and the MLA stuff is landed to so we are cleared to land this.

However, is the hopper/flash_api.cpp changes strictly necessary? im really really trying to reduces diffs with upstream to make sure we can sync easily and this is any upstream file, is there any chance we could move this stuff in to vllm_flash_attn/flash_attn_interface.py and use torch.expand to create a 0 stride?

This reverts commit 375edf5.

Signed-off-by: Mickael Seznec <[email protected]>
Signed-off-by: Mickael Seznec <[email protected]>
@mickaelseznec
Copy link
Author

Great, I didn't know about torch.expand(). I'll use it on vllm side to avoid any magic hidden in the interface layer.

Also, I've seen some API mismatches between torch.ops._vllm_fa3_C.fwd and how it's called in vllm_flash_attn/flash_attn_interface.py (alibi doesn't seem to have support in FA3)

@LucasWilkinson
Copy link
Collaborator

Great, I didn't know about torch.expand(). I'll use it on vllm side to avoid any magic hidden in the interface layer.

Awesome, thank you! Do you mind removing these bits from the flash_api.cpp in this PR?

Also, I've seen some API mismatches between torch.ops._vllm_fa3_C.fwd and how it's called in vllm_flash_attn/flash_attn_interface.py (alibi doesn't seem to have support in FA3)

oh good catch! oof not sure how that slipped by, PRs welcome :smiling:

@mickaelseznec
Copy link
Author

Hi @LucasWilkinson, I've updated my PR accordingly. Let me know if you have any further comments :)

@LucasWilkinson LucasWilkinson merged commit dc9d410 into vllm-project:main Mar 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants