cmake: get rid of empty VLLM_FA_GPU_ARCHES variable #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
force-pushed
the
remove-undefine-cmake-variable
branch
from
5e0747d to
c6aacdb
Compare
Signed-off-by: Daniele Trifirò <[email protected]>
dtrifiro
force-pushed
the
remove-undefine-cmake-variable
branch
from
c6aacdb to
a729e7c
Compare
|
@youkaichao could you also merge this one? thanks. |
jayhshah
pushed a commit
that referenced
this pull request
Aug 8, 2025
Signed-off-by: Daniele Trifirò <[email protected]> Signed-off-by: Jay Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @LucasWilkinson.
Related: vllm-project/vllm#21599