Skip to content

Conversation

@lsy323
Copy link
Collaborator

@lsy323 lsy323 commented Aug 5, 2025

Description

In #403, UtilityOutput.result is wrapped with UtilityResult from vllm.v1.engine

Tests

unit test

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

Signed-off-by: Siyuan Liu <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@lsy323
Copy link
Collaborator Author

lsy323 commented Aug 5, 2025

@lsy323 lsy323 merged commit dc464cc into main Aug 5, 2025
3 checks passed
@lsy323 lsy323 deleted the lsiyuan/fix-disagg-test branch August 5, 2025 22:46
KWang1998 pushed a commit that referenced this pull request Aug 6, 2025
Signed-off-by: Siyuan Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants