-
Notifications
You must be signed in to change notification settings - Fork 570
Bump torch version to 2.7.1 #1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
04ddefc to
7bab351
Compare
4f45d58 to
b67e468
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
- Coverage 76.41% 76.31% -0.11%
==========================================
Files 113 111 -2
Lines 12553 12485 -68
==========================================
- Hits 9593 9528 -65
+ Misses 2960 2957 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
e113a90 to
f10b808
Compare
Yikun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait torch npu 2.7.1 first POC version.
| # limitations under the License. | ||
| # This file is a part of the vllm-ascend project. | ||
| # | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert unrelated change to avoid cherrypick conflict
| size, | ||
| loop_cnt, | ||
| aiv_num); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert unrelated change to avoid cherrypick conflict
| int64_t aiv_num = 0; | ||
| TORCH_CHECK(aclGetDeviceCapability(device_id, ACL_DEVICE_INFO_VECTOR_CORE_NUM, &aiv_num) == ACL_SUCCESS); | ||
| uint32_t loop_cnt = (size + aiv_num - 1) / aiv_num; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert unrelated change to avoid cherrypick conflict
README.md
Outdated
| * Python >= 3.9, < 3.12 | ||
| * CANN >= 8.1.RC1 | ||
| * PyTorch >= 2.5.1, torch-npu >= 2.5.1.post1.dev20250619 | ||
| * PyTorch >= 2.7.1, torch-npu >= 2.7.1rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * PyTorch >= 2.7.1, torch-npu >= 2.7.1rc1 | |
| * PyTorch >= 2.7.1, torch-npu >= 2.7.1.dev20250724 |
README.zh.md
Outdated
| * Python >= 3.9, < 3.12 | ||
| * CANN >= 8.1.RC1 | ||
| * PyTorch >= 2.5.1, torch-npu >= 2.5.1.post1.dev20250619 | ||
| * PyTorch >= 2.5.1, torch-npu >= 2.7.1rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * PyTorch >= 2.5.1, torch-npu >= 2.7.1rc1 | |
| * PyTorch >= 2.5.1, torch-npu >= 2.7.1.dev20250724 |
pyproject.toml
Outdated
| "torch-npu==2.5.1.post1.dev20250619", | ||
| "torch>=2.5.1", | ||
| "torchvision<0.21.0", | ||
| "torch-npu==2.7.1rc1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "torch-npu==2.7.1rc1", | |
| "torch-npu==2.7.1.dev20250724", |
requirements.txt
Outdated
| --pre | ||
| --extra-index-url https://mirrors.huaweicloud.com/ascend/repos/pypi | ||
| torch-npu==2.5.1.post1.dev20250619 | ||
| torch-npu==2.7.1rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| torch-npu==2.7.1rc1 | |
| torch-npu==2.7.1.dev20250724 |
| @@ -1,4 +1,3 @@ | |||
| # | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert unrelated change
|
|
||
| assert is_hccl_available() | ||
|
|
||
| # TODO(Yizhou): The reason we need to set options while vllm does not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiz-liu FYI, we can finally clean up this, thanks for your note.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
2e3f6f3 to
ea79c67
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ea79c67 to
5af47d4
Compare
Signed-off-by: Yikun Jiang <[email protected]>
Signed-off-by: Yikun Jiang <[email protected]>
Co-authored-by: leo-pony <[email protected]> Signed-off-by: Yikun Jiang <[email protected]>
Signed-off-by: leo-pony <[email protected]>
5af47d4 to
6937b7d
Compare
### What this PR does / why we need it? Bump torch version to 2.7.1, and cleanup infer schema patch vllm-project@857f489 (vllm-project#837), this patch depends on also: vllm-project#1974 ### Does this PR introduce any user-facing change? No #### How was this patch tested? CI passed torch-npu 2.7.1rc1 install guide: https://gitee.com/ascend/pytorch/tree/v2.7.1/ install depending: ``` pip3 install pyyaml pip3 install setuptools ``` install torch-npu: Closes: vllm-project#1866 Closes: vllm-project#1390 - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@9af654c --------- Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: leo-pony <[email protected]> Co-authored-by: Yikun Jiang <[email protected]>
### What this PR does / why we need it? Bump torch version to 2.7.1, and cleanup infer schema patch vllm-project@857f489 (vllm-project#837), this patch depends on also: vllm-project#1974 ### Does this PR introduce any user-facing change? No #### How was this patch tested? CI passed torch-npu 2.7.1rc1 install guide: https://gitee.com/ascend/pytorch/tree/v2.7.1/ install depending: ``` pip3 install pyyaml pip3 install setuptools ``` install torch-npu: Closes: vllm-project#1866 Closes: vllm-project#1390 - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@9af654c --------- Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: leo-pony <[email protected]> Co-authored-by: Yikun Jiang <[email protected]>
### What this PR does / why we need it? Bump torch version to 2.7.1, and cleanup infer schema patch vllm-project@857f489 (vllm-project#837), this patch depends on also: vllm-project#1974 ### Does this PR introduce any user-facing change? No #### How was this patch tested? CI passed torch-npu 2.7.1rc1 install guide: https://gitee.com/ascend/pytorch/tree/v2.7.1/ install depending: ``` pip3 install pyyaml pip3 install setuptools ``` install torch-npu: Closes: vllm-project#1866 Closes: vllm-project#1390 - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@9af654c --------- Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: leo-pony <[email protected]> Co-authored-by: Yikun Jiang <[email protected]>
### What this PR does / why we need it? Bump torch version to 2.7.1, and cleanup infer schema patch vllm-project@857f489 (vllm-project#837), this patch depends on also: vllm-project#1974 ### Does this PR introduce any user-facing change? No #### How was this patch tested? CI passed torch-npu 2.7.1rc1 install guide: https://gitee.com/ascend/pytorch/tree/v2.7.1/ install depending: ``` pip3 install pyyaml pip3 install setuptools ``` install torch-npu: Closes: vllm-project#1866 Closes: vllm-project#1390 - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@9af654c --------- Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: leo-pony <[email protected]> Co-authored-by: Yikun Jiang <[email protected]>
What this PR does / why we need it?
Bump torch version to 2.7.1, and cleanup infer schema patch 857f489 (#837), this patch depends on also: #1974
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed
torch-npu 2.7.1rc1 install guide:
https://gitee.com/ascend/pytorch/tree/v2.7.1/
install depending:
install torch-npu:
Closes: #1866
Closes: #1390