[CI]Fix broken CI #1773
Merged
[CI]Fix broken CI #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
===========================================
+ Coverage 27.39% 54.48% +27.09%
===========================================
Files 56 82 +26
Lines 6191 10063 +3872
===========================================
+ Hits 1696 5483 +3787
- Misses 4495 4580 +85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wangxiyuan
commented
Jul 14, 2025
| from typing_extensions import ParamSpec | ||
| from vllm.engine.arg_utils import AsyncEngineArgs | ||
| from vllm.entrypoints.openai.cli_args import make_arg_parser | ||
| from vllm.model_executor.model_loader import get_model_loader |
Collaborator
Author
There was a problem hiding this comment.
import vllm.model_executor.model_loader here will lead torch infer_schema error. Since prompt_embedding only works in V0. Let's remove releated test for quick fix.
Signed-off-by: wangxiyuan <[email protected]>
wangxiyuan
commented
Jul 14, 2025
| scheduler.requests[req.request_id] = req | ||
| scheduler.running.append(req) | ||
| if not vllm_version_is("0.9.2"): | ||
| req.status = RequestStatus.RUNNING |
Collaborator
Author
There was a problem hiding this comment.
This change is adapted from vllm-project/vllm#20739
| from vllm_ascend.utils import adapt_patch # noqa E402 | ||
|
|
||
| adapt_patch(True) | ||
| adapt_patch(False) |
Collaborator
Author
There was a problem hiding this comment.
ensure torch patch is called.
Yikun
approved these changes
Jul 14, 2025
Collaborator
Yikun
left a comment
Yikun
left a comment
There was a problem hiding this comment.
Merge to main to recover CI
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
This PR fixed the broken CI. It require vllm-project/vllm#20900 merged first. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@e8cc53a Signed-off-by: wangxiyuan <[email protected]>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
This PR fixed the broken CI. It require vllm-project/vllm#20900 merged first. - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@e8cc53a Signed-off-by: wangxiyuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the broken CI. It require vllm-project/vllm#20900 merged first.