Skip to content

Conversation

@wxsIcey
Copy link
Collaborator

@wxsIcey wxsIcey commented Oct 13, 2025

What this PR does / why we need it?

[CI] Upgrade vllm to newest commit

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

CI passed

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the vllm dependency to its newest commit. The changes primarily consist of adapting the codebase to the new API of vllm, including updated function signatures, class inheritances, and import paths. My review of the changes indicates that these adaptations have been correctly implemented to ensure compatibility with the upgraded dependency. I did not find any critical or high-severity issues.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
@wxsIcey wxsIcey added ready-for-test start test by label for PR ready read for review labels Oct 17, 2025
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
Signed-off-by: Icey <[email protected]>
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wxsIcey wxsIcey closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants