Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented Nov 5, 2024

These were changed to separate blocks in #9759 but I feel it's cleaner/clearer as a single block. It actually doesn't matter which parts of the block raise the specific exceptions in the except clauses, we still want to handle them in the same way.

@njhill njhill requested a review from DarkLight1337 November 5, 2024 22:35
@github-actions
Copy link

github-actions bot commented Nov 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Nov 5, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind either way, but maybe we should also do this for chat endpoint to be consistent? (Originally I did it the other way round)

These were changed to separate blocks in vllm-project#9759 but I feel it's cleaner/clearer as a single block. It actually doesn't matter which parts of the block raise the specific exceptions in the except clauses, we still want to handle them in the same way.

Signed-off-by: Nick Hill <[email protected]>
@njhill
Copy link
Member Author

njhill commented Nov 6, 2024

Thanks @DarkLight1337 ... I think the chat endpoint is already like this (at least there aren't equivalent separate try/except blocks in the non-streaming impl).

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 7, 2024
@njhill njhill merged commit 29862b8 into vllm-project:main Nov 7, 2024
58 checks passed
@njhill njhill deleted the frontend-tweaks branch November 7, 2024 04:07
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants