Skip to content

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Dec 12, 2024

Summary:

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@dsikka dsikka changed the title [Bugfix [Bugfix] Update starcoder to remap k/v scale names for kv_cache quantization Dec 12, 2024
@dsikka dsikka changed the title [Bugfix] Update starcoder to remap k/v scale names for kv_cache quantization [Bugfix] Update starcoder2 to remap k/v scale names for kv_cache quantization Dec 12, 2024
@dsikka dsikka marked this pull request as ready for review December 12, 2024 20:54
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 13, 2024
@mgoin mgoin enabled auto-merge (squash) December 13, 2024 03:22
@mgoin mgoin merged commit 3989a79 into vllm-project:main Dec 13, 2024
70 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@dsikka dsikka deleted the update_kv_name branch May 15, 2025 00:52
@Edwardf0t1 Edwardf0t1 mentioned this pull request Aug 12, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants