Add contributing guideline and mypy config #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhuohan123 Sorry for updating the PR after requesting the review. Now the PR is ready for review. |
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
yukavio
pushed a commit
to yukavio/vllm
that referenced
this pull request
Jul 3, 2024
SUMMARY: - Miscellaneous updates to benchmarking infrastructure to support Github benchmarking UI - cleanup configs - Remove default arguments. - Add a `description` field to the benchmarking scripts so we may communicate intent to the UI - Move benchmark_result.py to logging folder - Add gha_benchmark_logging script that consumed BenchmarkResult JSON and outputs a JSON that the Github Benchmark UI can understand. - Add a minimal_test.json config that can be used for infra testing - Make config list as nightly explicity and add the remote-push job to nightly for fair comparison TEST PLAN: Manual testing nm-benchmark manual trigger : https://github.com/neuralmagic/nm-vllm/actions/runs/8284500798 nightly manual trigger : https://github.com/neuralmagic/nm-vllm/actions/runs/8285535882 --------- Co-authored-by: Varun Sundar Rabindranath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
This PR adds
CONTRIGUING.mdand mypy configs. While the repository currently does not completely pass the mypy tests, it helps me identify some type bugs in our codebase. Those bugs are also fixed in this PR.