-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Quant] Move to packed_modules_mapping
from class var to instance var
#13304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Quant] Move to packed_modules_mapping
from class var to instance var
#13304
Conversation
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
This pull request has merge conflicts that must be resolved before it can be |
…fig_mutable_default
Head branch was pushed to by a user without write access
The failing test is due to guided decoding CI issues |
Implemented by #13104 |
Pull request was closed
Purpose
packed_modules_mapping
from class var to instance var to avoid potentially unintentional sharing of class var valueChanges
packed_modules_mapping
to__init__
functionTesting
QuantizationConfig
subclasses usinggrep -Er 'class\s+\w+\s*\(\s*QuantizationConfig\s*\)\s*:' vllm