Skip to content

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Feb 14, 2025

Purpose

  • Move to packed_modules_mapping from class var to instance var to avoid potentially unintentional sharing of class var value

Changes

  • Add initialization of packed_modules_mapping to __init__ function

Testing

  • Find all instances of QuantizationConfig subclasses using grep -Er 'class\s+\w+\s*\(\s*QuantizationConfig\s*\)\s*:' vllm

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@mgoin mgoin added quantization ready ONLY add when PR is ready to merge/full CI is needed labels Feb 14, 2025
@mgoin mgoin enabled auto-merge (squash) February 14, 2025 19:38
Copy link

mergify bot commented Feb 14, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @kylesayrs.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 14, 2025
auto-merge was automatically disabled February 15, 2025 16:27

Head branch was pushed to by a user without write access

@mergify mergify bot removed the needs-rebase label Feb 15, 2025
@mgoin mgoin enabled auto-merge (squash) February 15, 2025 20:54
@mgoin
Copy link
Member

mgoin commented Feb 15, 2025

The failing test is due to guided decoding CI issues

@kylesayrs
Copy link
Contributor Author

Implemented by #13104

@kylesayrs kylesayrs closed this Feb 16, 2025
auto-merge was automatically disabled February 16, 2025 04:35

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force-merge quantization ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants