Skip to content

Conversation

catherinelee274
Copy link

@catherinelee274 catherinelee274 commented Feb 18, 2025

Introduce allowed_token_id support in v1 Sampler.

Tested with:
pytest tests/v1/sample/test_sampler.py -k "test_sampler_allowed_token_ids"

Fixes #13058

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 18, 2025
@njhill
Copy link
Member

njhill commented Feb 18, 2025

Thanks @catherinelee274! There is actually a PR already open for this though: #13210

@WoosukKwon
Copy link
Collaborator

@catherinelee274 Closing this as #13210 is merged. Thanks!

@WoosukKwon WoosukKwon closed this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[V1][Help Wanted] Porting missing sampling parameters to V1

3 participants