Skip to content

[Misc]Code Cleanup #13859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

[Misc]Code Cleanup #13859

merged 1 commit into from
Feb 26, 2025

Conversation

@noemotiovon
Copy link
Contributor

@noemotiovon noemotiovon commented Feb 26, 2025

Code cleanup: The assignment self.use_ray_spmd_worker = envs.VLLM_USE_RAY_SPMD_WORKER has already been made on line 69 and validated, so there is no need for redundant assignment here.

@noemotiovon
[Misc]Code Clean
c15e0dd 
Signed-off-by: noemotiovon <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 26, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@noemotiovon
Copy link
Contributor Author

noemotiovon commented Feb 26, 2025

@MengqingCao, cc.

@MengqingCao
Copy link
Contributor

MengqingCao commented Feb 26, 2025

lgtm, thanks for this fixing!

youkaichao
youkaichao approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youkaichao youkaichao merged commit e1fe759 into vllm-project:main Feb 26, 2025
10 of 17 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@noemotiovon @Akshat-Tripathi
[Misc]Code Cleanup (vllm-project#13859)
c1bc1ac 
Signed-off-by: noemotiovon <[email protected]>
Co-authored-by: noemotiovon <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@noemotiovon @lulmer
[Misc]Code Cleanup (vllm-project#13859)
d976d1e 
Signed-off-by: noemotiovon <[email protected]>
Co-authored-by: noemotiovon <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@noemotiovon @shreyankg
[Misc]Code Cleanup (vllm-project#13859)
7bbc015 
Signed-off-by: noemotiovon <[email protected]>
Co-authored-by: noemotiovon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youkaichao youkaichao youkaichao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noemotiovon @MengqingCao @youkaichao