Skip to content

Conversation

gnovack
Copy link
Contributor

@gnovack gnovack commented Mar 2, 2025

This PR is part of the effort to support vLLM v1 architecture on the neuron platform (see #11152). This change adds a device communicator class for the neuron backend using torch_xla.

Neuron-specific test cases are added to tests/neuron and are based on the existing distributed comms tests in tests/distributed/test_comm_ops.py

Copy link

github-actions bot commented Mar 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@gnovack gnovack marked this pull request as ready for review March 3, 2025 17:46
Copy link

mergify bot commented Mar 3, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @gnovack.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 3, 2025
@gnovack gnovack force-pushed the gnovack/neuron-v1-communicator branch from 0e5242a to 42b41e5 Compare March 4, 2025 21:15
Copy link
Contributor

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be better to signoff the commit to comply with DCO.

@aarondou @chongmni-aws please take another look

@simon-mo
Copy link
Collaborator

simon-mo commented Mar 7, 2025

@youkaichao @robertgshaw2-redhat would be great to get an understanding whether fits architecturally

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it only touches the neuron side code

@gnovack gnovack force-pushed the gnovack/neuron-v1-communicator branch 4 times, most recently from 5108f26 to d764a23 Compare March 7, 2025 16:53
@mergify mergify bot removed the needs-rebase label Mar 7, 2025
@gnovack gnovack force-pushed the gnovack/neuron-v1-communicator branch from d764a23 to ebec625 Compare March 7, 2025 17:13
@simon-mo simon-mo merged commit d612317 into vllm-project:main Mar 11, 2025
18 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants