-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[Neuron] Add Neuron device communicator for vLLM v1 #14085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neuron] Add Neuron device communicator for vLLM v1 #14085
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
0e5242a
to
42b41e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it would be better to signoff the commit to comply with DCO.
@aarondou @chongmni-aws please take another look
@youkaichao @robertgshaw2-redhat would be great to get an understanding whether fits architecturally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since it only touches the neuron side code
5108f26
to
d764a23
Compare
Signed-off-by: gnovack <[email protected]>
d764a23
to
ebec625
Compare
Signed-off-by: Louis Ulmer <[email protected]>
This PR is part of the effort to support vLLM v1 architecture on the neuron platform (see #11152). This change adds a device communicator class for the neuron backend using
torch_xla
.Neuron-specific test cases are added to
tests/neuron
and are based on the existing distributed comms tests intests/distributed/test_comm_ops.py