-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
forward fix PR 14245, restore build on ROCm 6.2 #14709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR vllm-project#14245 broke compilation for ROCm 6.2. Signed-off-by: Jeff Daily <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
ProExpertProg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
|
@jeffdaily Thank you for the fix! For the context, I'm experimenting with benchmarking vLLM v1 on an internal MI300X GPU (dashboard), and the host is on ROCm 6.2 and builds start to fail (we probably want to use OSS AMD runners to run this benchmark eventually). |
Signed-off-by: Jeff Daily <[email protected]>
|
I retried the failing CI job so let's hope this passes. |
tlrmchlsmth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and the explanation!
Signed-off-by: Jeff Daily <[email protected]> Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: Jeff Daily <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Jeff Daily <[email protected]>
Signed-off-by: Jeff Daily <[email protected]> Signed-off-by: Mu Huai <[email protected]>
PR #14245 broke compilation for ROCm 6.2.
__hip_fp8_e4m3 only exists starting in ROCm 6.3. PR #14245 added VLLM_DISPATCH_FP8_TYPES that on ROCm instantiates both OCP and FNUZ kernels. We need to replace the new __hip_fp8_e4m3 HW cvt with something reasonable that doesn't rely on the ROCm 6.3 feature. This allows compiling on ROCm 6.2 or newer.