Skip to content

Conversation

@jeffdaily
Copy link
Contributor

@jeffdaily jeffdaily commented Mar 12, 2025

PR #14245 broke compilation for ROCm 6.2.

__hip_fp8_e4m3 only exists starting in ROCm 6.3. PR #14245 added VLLM_DISPATCH_FP8_TYPES that on ROCm instantiates both OCP and FNUZ kernels. We need to replace the new __hip_fp8_e4m3 HW cvt with something reasonable that doesn't rely on the ROCm 6.3 feature. This allows compiling on ROCm 6.2 or newer.

PR vllm-project#14245 broke compilation for ROCm 6.2.

Signed-off-by: Jeff Daily <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@ProExpertProg ProExpertProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@huydhn
Copy link
Contributor

huydhn commented Mar 13, 2025

@jeffdaily Thank you for the fix! For the context, I'm experimenting with benchmarking vLLM v1 on an internal MI300X GPU (dashboard), and the host is on ROCm 6.2 and builds start to fail (we probably want to use OSS AMD runners to run this benchmark eventually).

@ProExpertProg
Copy link
Collaborator

I retried the failing CI job so let's hope this passes.

Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and the explanation!

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 13, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) March 13, 2025 22:47
@vllm-bot vllm-bot merged commit 2a602b0 into vllm-project:main Mar 14, 2025
68 of 70 checks passed
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants