-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[ROCm] Integrate AITER PagedAttention #14836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sage Moore <[email protected]>
Signed-off-by: Sage Moore <[email protected]>
Signed-off-by: Sage Moore <[email protected]>
Signed-off-by: Sage Moore <[email protected]>
Signed-off-by: Sage Moore <[email protected]>
Signed-off-by: Sage Moore <[email protected]>
Signed-off-by: Sage Moore <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…aiter-paged-attn
cc @tjtanaa |
@SageMoore I am working on enabling other AITER kernels AITER Linear, AITER Fused MoE, AITER RMSNorm, and AITER Block Scaled GEMM in other PRs. In the process, I will be enabling model level unit tests would be referring to I will also be updating the It would be preferrable to merge this PR after we at least get our first AITER PR merged with AITER model level unit test enabled, and proper |
if USE_AITER_PAGED_ATTN and kv_cache_dtype not in [ | ||
"int8", "fp8", "fp8_e4m3" | ||
]: | ||
logger.warning("ROCM AITER paged attention does not " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really fallback here? Only see the warning here.
This pull request has merge conflicts that must be resolved before it can be |
This PR is largely cut out from #14007 with a few modifications.