Skip to content

Conversation

@FredericOdermatt
Copy link

@FredericOdermatt FredericOdermatt commented Mar 19, 2025

Thanks guys for the awesome work!

I've noticed that XGrammar now supports regex strings xgrammar PR

This PR removes the fallback to outlines for regex for VLLM v0 users (backwards compatibility)

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@russellb
Copy link
Member

Thanks for the PR! I've got an older one for this here: #13228

I'm going to close this one out as a duplicate.

@russellb russellb closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants