Skip to content

[CI/Build] LoRA: Delete long context tests #15503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

[CI/Build] LoRA: Delete long context tests #15503

merged 1 commit into from
Mar 26, 2025

Conversation

@varun-sundar-rabindranath
Copy link
Contributor

@varun-sundar-rabindranath varun-sundar-rabindranath commented Mar 25, 2025 •
edited by github-actions bot
Loading

Remove LoRA long context tests as we don't know of any active users who use this feature.
The support for long context exists in code and we can add this test back based on user feedback.

remove long context tests
28c3c60 
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@varun-sundar-rabindranath
Copy link
Contributor Author

fyi @jeejeelee

@mergify mergify bot added the ci/build label Mar 25, 2025
@varun-sundar-rabindranath varun-sundar-rabindranath mentioned this pull request Mar 25, 2025
Merged
WoosukKwon
WoosukKwon approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. It'd be nice if @jeejeelee can give a second look

@jeejeelee
Copy link
Collaborator

It seems the testing time for lora-TP has been reduced by more than 10 minutes, cool

@WoosukKwon WoosukKwon merged commit ff38f0a into vllm-project:main Mar 26, 2025
19 checks passed
@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 26, 2025
wrmedford pushed a commit to wrmedford/vllm that referenced this pull request Mar 26, 2025
@varun-sundar-rabindranath @wrmedford
[CI/Build] LoRA: Delete long context tests (vllm-project#15503)
517f9fa 
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Co-authored-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Wes Medford <[email protected]>
@varun-sundar-rabindranath varun-sundar-rabindranath mentioned this pull request Mar 26, 2025
Merged
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@varun-sundar-rabindranath @lulmer
[CI/Build] LoRA: Delete long context tests (vllm-project#15503)
7e43c98 
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Co-authored-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@varun-sundar-rabindranath @lk-chen
[CI/Build] LoRA: Delete long context tests (vllm-project#15503)
706e704 
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Co-authored-by: Varun Sundar Rabindranath <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@varun-sundar-rabindranath @shreyankg
[CI/Build] LoRA: Delete long context tests (vllm-project#15503)
9744554 
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Co-authored-by: Varun Sundar Rabindranath <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@varun-sundar-rabindranath
[CI/Build] LoRA: Delete long context tests (vllm-project#15503)
7258fae 
Signed-off-by: Varun Sundar Rabindranath <[email protected]>
Co-authored-by: Varun Sundar Rabindranath <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@WoosukKwon WoosukKwon WoosukKwon approved these changes

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@varun-sundar-rabindranath @jeejeelee @WoosukKwon