Skip to content

Use numba 0.61 for python 3.10+ to support numpy>=2 #15692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2025
Merged

Use numba 0.61 for python 3.10+ to support numpy>=2 #15692

merged 1 commit into from
Mar 29, 2025

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 28, 2025

No description provided.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 28, 2025
@cyyever cyyever force-pushed the numba branch 3 times, most recently from c14b050 to bd5083a Compare March 28, 2025 09:53
mgoin
mgoin approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI. It would be great if this is the last requirement for numpy>=2.0.0. This is needed for python 3.13 as well #13164
cc @WoosukKwon

@mgoin mgoin requested a review from WoosukKwon March 28, 2025 15:02
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 28, 2025
mgoin
mgoin reviewed Mar 28, 2025
View reviewed changes
@WoosukKwon
Copy link
Collaborator

Actually, what is this change for?

@cyyever
Copy link
Contributor Author

cyyever commented Mar 28, 2025

To remove the limit on numpy

@mgoin mgoin changed the title Use numba 0.61 for python 3.10+ Use numba 0.61 for python 3.10+ to support numpy>=2 Mar 28, 2025
@WoosukKwon
Copy link
Collaborator

@cyyever Got it. Makes sense!

I'm ok if the CI is green.

@DarkLight1337 DarkLight1337 merged commit 8427f70 into vllm-project:main Mar 29, 2025
67 checks passed
@cyyever cyyever deleted the numba branch April 4, 2025 04:06
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@cyyever @Alex4210987
Use numba 0.61 for python 3.10+ to support numpy>=2 (vllm-project#15692)
aa30e2e 
Signed-off-by: cyy <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@cyyever @lulmer
Use numba 0.61 for python 3.10+ to support numpy>=2 (vllm-project#15692)
c648c16 
Signed-off-by: cyy <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@rgommers rgommers mentioned this pull request Apr 8, 2025
Closed
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@cyyever @lk-chen
Use numba 0.61 for python 3.10+ to support numpy>=2 (vllm-project#15692)
c80ec15 
Signed-off-by: cyy <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@cyyever @shreyankg
Use numba 0.61 for python 3.10+ to support numpy>=2 (vllm-project#15692)
e522968 
Signed-off-by: cyy <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@cyyever
Use numba 0.61 for python 3.10+ to support numpy>=2 (vllm-project#15692)
920d652 
Signed-off-by: cyy <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever @WoosukKwon @mgoin @DarkLight1337