Skip to content

[ROCm][Bugfix] Use platform specific FP8 dtype #15717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

[ROCm][Bugfix] Use platform specific FP8 dtype #15717

merged 1 commit into from
Apr 4, 2025

Conversation

gshtras
Copy link
Collaborator

@gshtras gshtras commented Mar 28, 2025

No description provided.

@gshtras
Use platform specific FP8 dtype
6c6d070 
Signed-off-by: Gregory Shtrasberg <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@gshtras gshtras mentioned this pull request Mar 28, 2025
Merged
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 3, 2025
@vllm-bot vllm-bot merged commit 40a36cc into vllm-project:main Apr 4, 2025
53 of 55 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@gshtras @Alex4210987
[ROCm][Bugfix] Use platform specific FP8 dtype (vllm-project#15717)
f8d210e 
Signed-off-by: Gregory Shtrasberg <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@gshtras @lulmer
[ROCm][Bugfix] Use platform specific FP8 dtype (vllm-project#15717)
cd1add6 
Signed-off-by: Gregory Shtrasberg <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@gshtras gshtras deleted the prefix_prefill_fp8_dtype branch April 7, 2025 14:58
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@gshtras @lk-chen
[ROCm][Bugfix] Use platform specific FP8 dtype (vllm-project#15717)
5014684 
Signed-off-by: Gregory Shtrasberg <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@gshtras @shreyankg
[ROCm][Bugfix] Use platform specific FP8 dtype (vllm-project#15717)
1e0e21d 
Signed-off-by: Gregory Shtrasberg <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@gshtras
[ROCm][Bugfix] Use platform specific FP8 dtype (vllm-project#15717)
bb6ed26 
Signed-off-by: Gregory Shtrasberg <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

+1 more reviewer

@SageMoore SageMoore SageMoore approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gshtras @mgoin @SageMoore @vllm-bot