Skip to content

[CI] Speed up V1 structured output tests #15718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2025
Merged

[CI] Speed up V1 structured output tests #15718

merged 2 commits into from
Mar 29, 2025

Conversation

@russellb
Copy link
Member

@russellb russellb commented Mar 28, 2025 •
edited by github-actions bot
Loading

Instead of creating a new LLM instance per test case, re-use the same
one for as much as possible. This drastically speeds up these tests in
my dev environment with an H100:

before: ~37 minutes
after: ~2.5 minutes

Signed-off-by: Russell Bryant [email protected]

@russellb
[CI] Speed up V1 structured output tests
f925501 
Instead of creating a new `LLM` instance per test case, re-use the same
one for as much as possible. This drastically speeds up these tests in
my dev envionment with an H100:

before: ~37 minutes
after: ~6.5 minutes

Signed-off-by: Russell Bryant <[email protected]>
@russellb russellb requested a review from mgoin as a code owner March 28, 2025 18:24
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 28, 2025
@russellb russellb requested a review from Copilot March 28, 2025 18:38
Copilot
Copilot AI reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@russellb russellb requested a review from Copilot March 28, 2025 18:40
Copilot
Copilot AI reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@russellb russellb added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 28, 2025
@russellb
add enforce_eager=True
10a3116 
Signed-off-by: Russell Bryant <[email protected]>
@mgoin mgoin enabled auto-merge (squash) March 28, 2025 19:48
jeejeelee
jeejeelee approved these changes Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@DarkLight1337
Copy link
Member

I have seen this test failure before this PR so I'll just merge this one first. Can you fix the CI failure in another PR?

@vllm-bot vllm-bot merged commit 7a79920 into vllm-project:main Mar 29, 2025
16 of 18 checks passed
@russellb
Copy link
Member Author

I have seen this test failure before this PR so I'll just merge this one first. Can you fix the CI failure in another PR?

Failure looks like it was caused by #15594

@russellb russellb mentioned this pull request Mar 29, 2025
Merged
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@russellb @Alex4210987
[CI] Speed up V1 structured output tests (vllm-project#15718)
4e7c76a 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@russellb @lulmer
[CI] Speed up V1 structured output tests (vllm-project#15718)
eb95f62 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@russellb @lk-chen
[CI] Speed up V1 structured output tests (vllm-project#15718)
be3b44b 
Signed-off-by: Russell Bryant <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@russellb @shreyankg
[CI] Speed up V1 structured output tests (vllm-project#15718)
3d1631a 
Signed-off-by: Russell Bryant <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@russellb
[CI] Speed up V1 structured output tests (vllm-project#15718)
a051fee 
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat left review comments

Copilot code review Copilot Copilot left review comments

@mgoin mgoin mgoin approved these changes

@jeejeelee jeejeelee jeejeelee approved these changes

@aarnphm aarnphm aarnphm approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@russellb @DarkLight1337 @mgoin @jeejeelee @aarnphm @robertgshaw2-redhat @vllm-bot