Skip to content

Conversation

chaunceyjiang
Copy link
Collaborator

@chaunceyjiang chaunceyjiang commented Mar 30, 2025

xgrammar structured output supports Enum.

Fix: https://buildkite.com/vllm/ci/builds/16518#0195de7e-5b32-42e7-b741-8747cb4985db

Failure it was caused by #15594

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 30, 2025
@chaunceyjiang
Copy link
Collaborator Author

test

pytest tests/v1/structured_output/test_utils.py -s -v
image

@chaunceyjiang
Copy link
Collaborator Author

/cc @russellb @DarkLight1337 PTAL.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 30, 2025 02:26
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 30, 2025
@vllm-bot vllm-bot merged commit 0455337 into vllm-project:main Mar 30, 2025
20 of 24 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants