Skip to content

Conversation

@aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Mar 31, 2025

This PR bumps version of xgrammar to 0.1.17 given the recent version adds support for minLength, maxLength in JSON schema.

Signed-off-by: Aaron Pham [email protected]

@aarnphm aarnphm requested review from mgoin and russellb as code owners March 31, 2025 04:39
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

return True

# Unsupported keywords for strings
if obj.get("type") == "string" and any(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit tests, similar to [PR #15594].

@mergify mergify bot added the tpu Related to Google TPUs label Apr 9, 2025
@mergify
Copy link

mergify bot commented Apr 9, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@russellb
Copy link
Member

superseded by #16516

@russellb russellb closed this Apr 12, 2025
@aarnphm aarnphm deleted the feat/support-min-maxlength branch April 12, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants