-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[V1][Metrics] Fix http metrics middleware #15894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
8d9a477
to
997498c
Compare
Rebased to pick up #15892 which should fix some of the |
@markmc this looks good, can you rebase? |
This pull request has merge conflicts that must be resolved before it can be |
PR vllm-project#15657 hooked up prometheus_fastapi_instrumentator but only for V0. Signed-off-by: Mark McLoughlin <[email protected]>
997498c
to
35c707b
Compare
Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
PR #15657 hooked up
prometheus_fastapi_instrumentator
but only for V0.