Skip to content

[Bugfix][kernels] Fix half2float conversion in gguf kernels #15995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

[Bugfix][kernels] Fix half2float conversion in gguf kernels #15995

merged 3 commits into from
Apr 4, 2025

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Apr 3, 2025 •
edited by github-actions bot
Loading

  • Fix broken cu118 release CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 3, 2025
@Isotr0py Isotr0py changed the title [Bugfix] Fix half2float conversion in gguf kernels [Bugfix][kernels] Fix half2float conversion in gguf kernels Apr 3, 2025
@jeejeelee jeejeelee enabled auto-merge (squash) April 3, 2025 12:43
@vllm-bot vllm-bot merged commit 230b131 into vllm-project:main Apr 4, 2025
68 of 69 checks passed
@Isotr0py Isotr0py deleted the fix-gguf-cu118 branch April 5, 2025 02:10
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@Isotr0py @Alex4210987
[Bugfix][kernels] Fix half2float conversion in gguf kernels (vllm-pro…
eb0bcd8 
…ject#15995)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Isotr0py @lulmer
[Bugfix][kernels] Fix half2float conversion in gguf kernels (vllm-pro…
6ab7513 
…ject#15995)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@Isotr0py @lk-chen
[Bugfix][kernels] Fix half2float conversion in gguf kernels (vllm-pro…
0661cd1 
…ject#15995)

Signed-off-by: Isotr0py <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Isotr0py @shreyankg
[Bugfix][kernels] Fix half2float conversion in gguf kernels (vllm-pro…
3026805 
…ject#15995)

Signed-off-by: Isotr0py <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Isotr0py
[Bugfix][kernels] Fix half2float conversion in gguf kernels (vllm-pro…
3414d06 
…ject#15995)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Isotr0py @mgoin @vllm-bot