-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
doc: add info for macos clang errors #16049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yihong0618 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
Just a couple of style nits.
Signed-off-by: yihong0618 <[email protected]>
Thank you for your review, address and left a concern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 4ef0bb1. Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]> Signed-off-by: xinyuxiao <[email protected]>
…llm-project#16091) Signed-off-by: yihong0618 <[email protected]> Signed-off-by: xinyuxiao <[email protected]>
Signed-off-by: yihong0618 <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…llm-project#16091) Signed-off-by: yihong0618 <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…llm-project#16091) Signed-off-by: yihong0618 <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
…llm-project#16091) Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]> Signed-off-by: Mu Huai <[email protected]>
…llm-project#16091) Signed-off-by: yihong0618 <[email protected]> Signed-off-by: Mu Huai <[email protected]>
FIX #15941
Mac info for issue #15941 make sure the apple clang version is 15 or 16
info from issue