Skip to content

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Apr 4, 2025

FIX #15941

Mac info for issue #15941 make sure the apple clang version is 15 or 16

info from issue

17 will cause the problem,
the main reason is from here ImportError("dlopen(/Users/aiserver/AI/vllm/vllm/_C.abi3.so, 0x0002): symbol not found in flat namespace '___kmpc_dispatch_deinit'")
and for clang17 in mac there can not find ___kmpc_dispatch_deinit symbol
it had been fixed in llvm and other version
more can check:
issue: https://trac.macports.org/ticket/70877
yugabyte/yugabyte-db-thirdparty#298
llvm/llvm-project#98046
will open a doc patch to info it
and for the solutin
setps

clang --version # make sure it is not 17
# if 17
sudo rm -rf /Library/Developer/CommandLineTools
# then go to https://developer.apple.com/download/all/
# download the  `Command Line Tools for Xcode 16.1`
# insatll it
# then 
clang --version # make sure its 16

Copy link

github-actions bot commented Apr 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 4, 2025
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

Just a couple of style nits.

Signed-off-by: yihong0618 <[email protected]>
@yihong0618
Copy link
Contributor Author

Thank you for your review, address and left a concern

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmellor hmellor enabled auto-merge (squash) April 4, 2025 14:10
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 4, 2025
@hmellor hmellor merged commit 4ef0bb1 into vllm-project:main Apr 4, 2025
36 of 40 checks passed
yihong0618 added a commit to yihong0618/vllm that referenced this pull request Apr 5, 2025
hmellor pushed a commit that referenced this pull request Apr 5, 2025
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: torch.ops._C.silu_and_mul does not exist

2 participants