Skip to content

[V1][BugFix] Exit properly if engine core fails during startup #16137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2025
Merged

[V1][BugFix] Exit properly if engine core fails during startup #16137

merged 4 commits into from
Apr 7, 2025

Conversation

@njhill
Copy link
Member

@njhill njhill commented Apr 6, 2025 •
edited by github-actions bot
Loading

Problem introduced by #15906

Also change polling info message to debug.

@njhill njhill added bug Something isn't working v1 needs-tests Tests needed for this PR labels Apr 6, 2025
@github-actions
Copy link

github-actions bot commented Apr 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@njhill njhill mentioned this pull request Apr 6, 2025
Merged
@njhill
Add unit test
3334878 
Signed-off-by: Nick Hill <[email protected]>
@njhill njhill added ready ONLY add when PR is ready to merge/full CI is needed and removed needs-tests Tests needed for this PR labels Apr 6, 2025
@mergify mergify bot added the ci/build label Apr 6, 2025
@njhill njhill merged commit 7f6d47c into vllm-project:main Apr 7, 2025
67 checks passed
@njhill njhill deleted the fiz-zmq-start-fail branch April 7, 2025 22:30
houseroad
houseroad reviewed Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the issue. Will report back if we still see the issue.

@njhill njhill mentioned this pull request Apr 8, 2025
Closed
1 task
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@njhill @yangw-dev
[V1][BugFix] Exit properly if engine core fails during startup (vllm-…
ab97c77 
…project#16137)

Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@njhill @lk-chen
[V1][BugFix] Exit properly if engine core fails during startup (vllm-…
9d891b3 
…project#16137)

Signed-off-by: Nick Hill <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@njhill
[V1][BugFix] Exit properly if engine core fails during startup (vllm-…
fe657d3 
…project#16137)

Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad left review comments

@simon-mo simon-mo simon-mo approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

bug Something isn't working ci/build ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@njhill @simon-mo @houseroad