Skip to content

[Bugfix] Re-enable support for ChatGLMForConditionalGeneration #16187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

[Bugfix] Re-enable support for ChatGLMForConditionalGeneration #16187

merged 1 commit into from
Apr 7, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Apr 7, 2025 •
edited by github-actions bot
Loading

ChatGLM3 originally had ChatGLMForConditionalGeneration architecture before being changed to ChatGLMModels. As a result, models derived from the original version may still use this architecture. This PR re-enables support for those models.

FIX #16183

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 7, 2025
@DarkLight1337 DarkLight1337 requested a review from jeejeelee April 7, 2025 12:41
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner April 7, 2025 12:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Apr 7, 2025
Closed
1 task
@DarkLight1337 DarkLight1337 changed the title [Bugfix] Re-enable support for legacy ChatGLMForConditionalGeneration models [Bugfix] Re-enable support for ChatGLMForConditionalGeneration Apr 7, 2025
@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 7, 2025
@DarkLight1337 DarkLight1337 merged commit 027b204 into vllm-project:main Apr 7, 2025
46 checks passed
@DarkLight1337 DarkLight1337 deleted the chatglm-error branch April 7, 2025 15:16
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@DarkLight1337 @yangw-dev
[Bugfix] Re-enable support for ChatGLMForConditionalGeneration (vll…
a679476 
…m-project#16187)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337 @lk-chen
[Bugfix] Re-enable support for ChatGLMForConditionalGeneration (vll…
b6c3784 
…m-project#16187)

Signed-off-by: DarkLight1337 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Bugfix] Re-enable support for ChatGLMForConditionalGeneration (vll…
b2ac536 
…m-project#16187)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: ValueError: ChatGLMForConditionalGeneration has no vLLM implementation and the Transformers implementation is not compatible with vLLM.

2 participants

@DarkLight1337 @jeejeelee