Skip to content

Conversation

loginaway
Copy link

@loginaway loginaway commented Apr 9, 2025

Deepcopying sampling_params that include LogitsProcessor might lead to OOM. This has been an old issue here:

#3087

and the previous commit #3099 fixed this issue in vllm/engine/llm_engine.py

However it is re-occurring in vllm/sequence.py. This commit is trying to fix this again.

…copied

Deepcopying sampling_params that include LogitsProcessor might lead to OOM. This has been an old issue here:

vllm-project#3087

and the previous commit fixed this issue in vllm/engine/llm_engine.py

https://github.com/vllm-project/vllm/pull/3099/files
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Fix the pre-commit, also is it a way to add a unittest to guard this?

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Jul 9, 2025
@mergify
Copy link

mergify bot commented Jul 9, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @loginaway.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 9, 2025
@github-actions github-actions bot added unstale Recieved activity after being labelled stale and removed stale Over 90 days of inactivity labels Jul 11, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added stale Over 90 days of inactivity and removed unstale Recieved activity after being labelled stale labels Oct 10, 2025
@njhill njhill added the v0 label Oct 10, 2025
@njhill
Copy link
Member

njhill commented Oct 10, 2025

closing as obsolete

@njhill njhill closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase stale Over 90 days of inactivity v0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants