Skip to content

Conversation

@Chenyaaang
Copy link
Contributor

@Chenyaaang Chenyaaang commented Apr 10, 2025

follow up #15724

After setting structured output backend to auto, update the benchmark script to also accept "auto" as structured-output-backend.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see now, nice! Auto is now the default for both v0 and v1 right?

@mgoin mgoin added ready ONLY add when PR is ready to merge/full CI is needed structured-output labels Apr 10, 2025
@russellb
Copy link
Member

Oh I see now, nice! Auto is now the default for both v0 and v1 right?

Yeah. In V0, auto is an alias for xgrammar. In V1, auto is the default and xgrammar is with no fallback.

@Chenyaaang
Copy link
Contributor Author

Oh I see now, nice! Auto is now the default for both v0 and v1 right?

Yes, my understanding is v0 and v1 can both use auto. In v0 auto will fallback to xgrammar, while in V1 auto will select from xgrammar and guidance.

@DarkLight1337 DarkLight1337 merged commit d544d14 into vllm-project:main Apr 11, 2025
42 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants