Skip to content

Better error message for missing mistral params.json #17132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Better error message for missing mistral params.json #17132

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
667dde0
Better error message for missing mistral params.json
mgoin Apr 24, 2025
fca8b82
Merge branch 'main' into better-mistral-config-error-message
mgoin Apr 24, 2025
d5643a3
FIx type
mgoin Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vllm/transformers_utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,11 @@ def load_params_config(model: Union[str, Path], revision: Optional[str],
config_file_name = "params.json"

config_dict = get_hf_file_to_dict(config_file_name, model, revision)
if config_dict is None:
raise ValueError(
f"Failed to load mistral '{config_file_name}' config for model "
f"{model}. Please check if the model is a mistral-format model "
f"and if the config file exists.")
assert isinstance(config_dict, dict)

config_mapping = {
Expand Down