Skip to content

[Misc] Remove deprecated files #17447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

[Misc] Remove deprecated files #17447

merged 1 commit into from
Apr 30, 2025

Conversation

@chaunceyjiang
Copy link
Collaborator

@chaunceyjiang chaunceyjiang commented Apr 30, 2025 •
edited by github-actions bot
Loading

PR #12955 forgot to remove this file during the refactoring.

@chaunceyjiang
[Misc] Remove deprecated files
39da45f 
Signed-off-by: chaunceyjiang <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 30, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@chaunceyjiang
Copy link
Collaborator Author

chaunceyjiang commented Apr 30, 2025

@gaocegege PTAL.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 30, 2025 05:56
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 30, 2025
@gaocegege
Copy link
Contributor

gaocegege commented Apr 30, 2025

Thanks for the fix.

@vllm-bot vllm-bot merged commit 1534d38 into vllm-project:main Apr 30, 2025
49 of 53 checks passed
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
@chaunceyjiang @radeksm
[Misc] Remove deprecated files (vllm-project#17447)
2a91809 
Signed-off-by: chaunceyjiang <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@chaunceyjiang
[Misc] Remove deprecated files (vllm-project#17447)
54bf2ee 
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@chaunceyjiang
[Misc] Remove deprecated files (vllm-project#17447)
6ae537a 
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@mgoin mgoin Awaiting requested review from mgoin

@russellb russellb Awaiting requested review from russellb

+1 more reviewer

@gaocegege gaocegege gaocegege approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

Structured Output
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chaunceyjiang @gaocegege @DarkLight1337 @vllm-bot