Skip to content

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 30, 2025

Changes:

  • Ported from sphinx.ext.autodoc and sphinx.ext.autosummary to autodoc2:
    • autodoc2 supports myst (markdown) so we can stop writing rst formatted docstrings
    • The entire codebase is documented in API Reference
    • All of these docs can be cross-referenced throughout the docs
  • Updated the API Reference index to include all the important classes/functions we already singled out on the individual pages we had before (reduces users having to click around and shows a more global picture of the APIs we expect them to be using)
  • autodoc2 statically analyses the code so:
    • No more mocked import issues outside of docs/
    • Greatly reduced requirements/docs.txt
    • RTD builds are slower because this analysis takes time
  • sphinx.ext.linkcode no longer requires vllm to be importable

This should help JSON CLI args document themselves (such as in #17420)

hmellor added 3 commits April 30, 2025 17:36
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor changed the title Add-config-docs Add config classes to API docs Apr 30, 2025
@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 30, 2025
Signed-off-by: Harry Mellor <[email protected]>
hmellor added 2 commits April 30, 2025 18:57
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
@aarnphm aarnphm requested a review from DarkLight1337 April 30, 2025 20:28
@hmellor
Copy link
Member Author

hmellor commented Apr 30, 2025

I almost have a patch that replaces autodoc and handles API documentation much better in general.

Let's hold off on merging this until that is ready

@hmellor hmellor changed the title Add config classes to API docs Add full API docs and improve the UX of navigating them May 1, 2025
@mergify mergify bot removed the needs-rebase label May 2, 2025
@DarkLight1337
Copy link
Member

Hmm it's still a bit difficult to navigate to the API docs of specific modules. Can we make Offline Inference, vLLM Engines etc. sub-pages under Summary, and similar for the "vllm" auto-generated pages?

@hmellor
Copy link
Member Author

hmellor commented May 3, 2025

Ok, currently working on improving the left sidebar so that the entire API can be navigated properly

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. Thanks for improving the dev experience!

@DarkLight1337
Copy link
Member

To avoid breaking stuff, let's wait for #17607 to unblock CI

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 3, 2025
@vllm-bot vllm-bot merged commit d6484ef into vllm-project:main May 4, 2025
77 of 80 checks passed
@hmellor hmellor deleted the add-config-docs branch May 4, 2025 08:06
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation frontend multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants