Skip to content

[Bugfix][ROCm] Using device_type because on ROCm the API is still torch.cuda #17601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

[Bugfix][ROCm] Using device_type because on ROCm the API is still torch.cuda #17601

merged 1 commit into from
May 3, 2025

Conversation

@gshtras
Copy link
Collaborator

@gshtras gshtras commented May 2, 2025 •
edited by github-actions bot
Loading

To fix regression from #17100
On ROCm:
device_name = "rocm"
device_type = "cuda"

The torch API is the same as for CUDA: torch.cuda.Event, etc.

@github-actions
Copy link

github-actions bot commented May 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added bug Something isn't working rocm Related to AMD ROCm ready ONLY add when PR is ready to merge/full CI is needed labels May 2, 2025
gshtras added a commit to ROCm/vllm that referenced this pull request May 2, 2025
@gshtras
Merge pull request #536 from ROCm/upstream_merge_2025_04_29
2fea69f 
Upstream merge 2025 04 29
Including vllm-project#17601
@vllm-bot vllm-bot merged commit a928424 into vllm-project:main May 3, 2025
67 of 70 checks passed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@gshtras
[Bugfix][ROCm] Using device_type because on ROCm the API is still tor…
fdb00a4 
…ch.cuda (vllm-project#17601)

Signed-off-by: Gregory Shtrasberg <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@gshtras @mawong-amd
[Bugfix][ROCm] Using device_type because on ROCm the API is still tor…
f240c79 
…ch.cuda (vllm-project#17601)

Signed-off-by: Gregory Shtrasberg <[email protected]>
@gshtras gshtras deleted the using_device_type branch May 19, 2025 20:14
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@gshtras
[Bugfix][ROCm] Using device_type because on ROCm the API is still tor…
bc97054 
…ch.cuda (vllm-project#17601)

Signed-off-by: Gregory Shtrasberg <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@mgoin mgoin mgoin approved these changes

Assignees

No one assigned

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gshtras @tlrmchlsmth @mgoin @vllm-bot