Skip to content

[Misc] V0 fallback for --enable-prompt-embeds #17615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

[Misc] V0 fallback for --enable-prompt-embeds #17615

merged 1 commit into from
May 3, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 3, 2025
@DarkLight1337 DarkLight1337 requested a review from njhill May 3, 2025 16:24
@github-actions
Copy link

github-actions bot commented May 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request May 3, 2025
Merged
njhill
njhill approved these changes May 3, 2025
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DarkLight1337

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 3, 2025 16:51
@DarkLight1337 DarkLight1337 merged commit 46fae69 into vllm-project:main May 3, 2025
56 checks passed
@DarkLight1337 DarkLight1337 deleted the prompt-embeds-raise-or-fallback branch May 3, 2025 22:59
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
[Misc] V0 fallback for --enable-prompt-embeds (vllm-project#17615)
9cfc65a 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@DarkLight1337 @mawong-amd
[Misc] V0 fallback for --enable-prompt-embeds (vllm-project#17615)
0104a60 
Signed-off-by: DarkLight1337 <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@DarkLight1337
[Misc] V0 fallback for --enable-prompt-embeds (vllm-project#17615)
05a5d5b 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
@qthequartermasterman qthequartermasterman mentioned this pull request Aug 2, 2025
Closed
1 task
@qthequartermasterman qthequartermasterman mentioned this pull request Sep 11, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@njhill njhill njhill approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DarkLight1337 @mgoin @njhill