Skip to content

Conversation

@xinli-sw
Copy link
Contributor

@xinli-sw xinli-sw commented May 10, 2025

Fix a rare care where specifying --revision does not change the behavior of huggingface processors (i.e. multi-modal video/image processors)

Seems like revision is being honored in all places other than vllm/transformers_utils/processor.py

~/projects/vllm$ grep -rin -l "\.from_pretrained(" ./vllm/
./vllm/model_executor/model_loader/neuronx_distributed.py
./vllm/model_executor/model_loader/neuron.py
./vllm/benchmarks/throughput.py
./vllm/transformers_utils/processor.py
./vllm/transformers_utils/config.py
./vllm/transformers_utils/tokenizer_base.py
./vllm/transformers_utils/tokenizer.py

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 11, 2025 03:04
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 11, 2025
@DarkLight1337 DarkLight1337 merged commit 90d0a74 into vllm-project:main May 11, 2025
88 checks passed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
wangxiyuan pushed a commit to vllm-project/vllm-ascend that referenced this pull request May 22, 2025
### What this PR does / why we need it?

Update transformer utils patch for `v0.7.3`.

This PR is a supplement to
#858, adding more patch
methods adapted from vllm-project/vllm#17948 to
solve `revision` problems in more scenarios besides
#829.

### Does this PR introduce _any_ user-facing change?

no.

### How was this patch tested?

```bash
vllm serve Qwen/Qwen2.5-VL-7B-Instruct \
--dtype bfloat16 \
--max_model_len 32768 \
--max-num-batched-tokens 32768
```

Signed-off-by: shen-shanshan <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants