Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented May 12, 2025

Update CT FP4 weight only path to use the nvfp4 dense marlin kernels from #17687 and remove slow emulation

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@dsikka
Copy link
Contributor

dsikka commented May 12, 2025

Evals - Using CT with NVFp4A16 for a LLama 3.1 8b:

vllm (pretrained=nm-testing/Llama-3.1-8B-Instruct-FP4-Weight,add_bos_token=True), gen_kwargs: (None), limit: None, num_fewshot: None, batch_size: 100
|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.7301|±  |0.0122|
|     |       |strict-match    |     5|exact_match|↑  |0.6376|±  |0.0132|

@mgoin mgoin marked this pull request as ready for review May 12, 2025 17:24
Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mgoin mgoin added quantization ready ONLY add when PR is ready to merge/full CI is needed labels May 12, 2025
@mgoin mgoin added this to the v0.9.0 milestone May 13, 2025
@mgoin mgoin merged commit 307939f into vllm-project:main May 13, 2025
96 checks passed
@mgoin mgoin deleted the nvfp4-marlin-ct branch May 13, 2025 00:07
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: mgoin <[email protected]>
Signed-off-by: Dipika <[email protected]>
Co-authored-by: Dipika <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quantization ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants