Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented May 12, 2025

These require the recently added VLLM_ALLOW_INSECURE_SERIALIZATION env var to be set.

Introduced in #17490.

These require the recently added VLLM_ALLOW_INSECURE_SERIALIZATION env var to be set.

Signed-off-by: Nick Hill <[email protected]>
@njhill njhill added the bug Something isn't working label May 12, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@russellb russellb enabled auto-merge (squash) May 12, 2025 17:55
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 12, 2025
@njhill
Copy link
Member Author

njhill commented May 12, 2025

I enabled some extra tests to run. I'm not 100% sure but I don't think the remaining failing ones are related to the pickle thing.

@vllm-bot vllm-bot merged commit ee5be83 into vllm-project:main May 13, 2025
120 of 124 checks passed
@njhill njhill deleted the fix-4gpu-test branch May 13, 2025 14:41
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants