-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[Doc] Unify structured outputs examples #18196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Aaron Pham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a fan of the consolidation!
While we're revamping this example, what do you think about the idea of adding a README for the example too? Then we would have a really nice (and easily extendable) example, similar to https://docs.vllm.ai/en/latest/getting_started/examples/prometheus_grafana.html
The folder structure would look something like this:
- examples
- online_serving
- structured_output
- README.md
- structured_output.py
(calling the .md
file README means it'll get rendered on GitHub as well as in the docs!)
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
1c1284f
to
9b9db68
Compare
Signed-off-by: Aaron Pham <[email protected]>
9b9db68
to
127183c
Compare
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Aaron Pham <[email protected]>
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
1 similar comment
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This PR unify the three files for structured_outputs examples onto one,
openai_chat_completion_structured_outputs.py
:--reasoning
--stream
Signed-off-by: Aaron Pham [email protected]