Skip to content

Conversation

aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented May 15, 2025

This PR unify the three files for structured_outputs examples onto one, openai_chat_completion_structured_outputs.py:

  • Now we will run with all supported features (regex, choice, structural_tags, json, grammar)
  • enable for reasoning trace with --reasoning
  • enable streaming outputs with --stream

Signed-off-by: Aaron Pham [email protected]

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label May 15, 2025
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm aarnphm requested review from hmellor and russellb May 15, 2025 09:14
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of the consolidation!

While we're revamping this example, what do you think about the idea of adding a README for the example too? Then we would have a really nice (and easily extendable) example, similar to https://docs.vllm.ai/en/latest/getting_started/examples/prometheus_grafana.html

The folder structure would look something like this:

- examples
  - online_serving
    - structured_output
      - README.md
      - structured_output.py

(calling the .md file README means it'll get rendered on GitHub as well as in the docs!)

aarnphm added 5 commits May 16, 2025 05:01
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm aarnphm requested a review from hmellor May 16, 2025 07:39
@aarnphm aarnphm force-pushed the chore/unify-examples branch from 1c1284f to 9b9db68 Compare May 16, 2025 07:56
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm aarnphm force-pushed the chore/unify-examples branch from 9b9db68 to 127183c Compare May 16, 2025 07:58
Copy link

mergify bot commented May 22, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 22, 2025
@mergify mergify bot removed the needs-rebase label May 23, 2025
Copy link

mergify bot commented May 26, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 26, 2025
@mergify mergify bot removed the needs-rebase label May 27, 2025
Signed-off-by: Aaron Pham <[email protected]>
Copy link

mergify bot commented May 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 30, 2025
@mergify mergify bot removed the needs-rebase label Jun 12, 2025
@aarnphm aarnphm requested a review from DarkLight1337 June 12, 2025 10:17
@aarnphm aarnphm enabled auto-merge (squash) June 12, 2025 18:59
@aarnphm aarnphm requested a review from DarkLight1337 June 12, 2025 18:59
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 12, 2025
@aarnphm aarnphm merged commit dba68f9 into vllm-project:main Jun 12, 2025
55 checks passed
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

1 similar comment
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@aarnphm aarnphm deleted the chore/unify-examples branch June 12, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants