Skip to content

Conversation

gshtras
Copy link
Collaborator

@gshtras gshtras commented May 15, 2025

Revert to the previous version of the triton attention kernel, modified to support FP8 computation.
The kernel brought in in #12591 turned out to have performance issues, and broken support for FP8 quantized models.
Until that is resolved we want to replace it from the performant version from the ROCm fork

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@gshtras gshtras force-pushed the old_triton_kernel branch from 186baa5 to 72dcbc3 Compare May 15, 2025 20:56
@mergify mergify bot removed the tpu Related to Google TPUs label May 15, 2025
@gshtras gshtras closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant