Skip to content

[Misc] refactor: simplify EngineCoreClient.make_async_mp_client in AsyncLLM #18817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

[Misc] refactor: simplify EngineCoreClient.make_async_mp_client in AsyncLLM #18817

merged 1 commit into from
Jun 4, 2025

Conversation

@googs1025
Copy link
Contributor

@googs1025 googs1025 commented May 28, 2025 •
edited by github-actions bot
Loading

  • just use EngineCoreClient.make_async_mp_client to init client for AsyncLLM

FIX None

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@googs1025 googs1025 force-pushed the refactor/make_client branch from dc945b4 to db1fbbf Compare May 28, 2025 07:42
@mergify mergify bot added the v1 label May 28, 2025
@googs1025 googs1025 changed the title refactor: simplify EngineCoreClient.make_client in AsyncLLM [Misc] refactor: simplify EngineCoreClient.make_client in AsyncLLM May 28, 2025
@googs1025 googs1025 force-pushed the refactor/make_client branch 4 times, most recently from e3d533e to 3d42e18 Compare May 28, 2025 08:43
@googs1025 googs1025 changed the title [Misc] refactor: simplify EngineCoreClient.make_client in AsyncLLM [Misc] refactor: simplify EngineCoreClient.make_async_mp_client in AsyncLLM May 28, 2025
@googs1025 googs1025 force-pushed the refactor/make_client branch 2 times, most recently from 5ecdcf9 to 908872d Compare May 28, 2025 09:37
googs1025
googs1025 commented May 28, 2025
View reviewed changes
vllm/v1/engine/async_llm.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the make_async_mp_client method instead of importing Client, which can reduce code maintenance costs

googs1025
googs1025 commented May 28, 2025
View reviewed changes
@googs1025
Copy link
Contributor Author

@DarkLight1337 @WoosukKwon /PTAL

@DarkLight1337
Copy link
Member

cc @njhill

@mergify
Copy link

mergify bot commented May 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @googs1025.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 30, 2025
@googs1025 googs1025 force-pushed the refactor/make_client branch from 908872d to f13b12f Compare May 30, 2025 15:51
@mergify mergify bot removed the needs-rebase label May 30, 2025
@googs1025 googs1025 force-pushed the refactor/make_client branch 2 times, most recently from 9828b82 to 2dc8d11 Compare May 31, 2025 00:17
@googs1025
Copy link
Contributor Author

@njhill can you help me this?

njhill
njhill reviewed Jun 1, 2025
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @googs1025, LGTM. Let's wait for #18779 to be merged though since this will need to be updated after that.

@mergify
Copy link

mergify bot commented Jun 3, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @googs1025.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jun 3, 2025
@googs1025 googs1025 force-pushed the refactor/make_client branch from 2dc8d11 to bcd34f3 Compare June 3, 2025 13:48
@mergify mergify bot removed the needs-rebase label Jun 3, 2025
@googs1025 googs1025 force-pushed the refactor/make_client branch from bcd34f3 to c1bc297 Compare June 3, 2025 14:02
@njhill
Copy link
Member

njhill commented Jun 3, 2025

@googs1025 LGTM, there's just a pre-commit error that needs fixing.

@googs1025 googs1025 force-pushed the refactor/make_client branch from c1bc297 to 2253bf8 Compare June 4, 2025 00:39
@googs1025
Copy link
Contributor Author

@googs1025 LGTM, there's just a pre-commit error that needs fixing.

done

@googs1025 googs1025 requested a review from njhill June 4, 2025 15:43
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 4, 2025
@njhill njhill merged commit 23027e2 into vllm-project:main Jun 4, 2025
73 checks passed
leoli1208 pushed a commit to leoli1208/vllm that referenced this pull request Jul 22, 2025
@googs1025 @leoli1208
[Misc] refactor: simplify EngineCoreClient.make_async_mp_client in As…
6fee0db 
…yncLLM (vllm-project#18817)

Signed-off-by: googs1025 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njhill njhill njhill approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@googs1025 @DarkLight1337 @njhill