Skip to content

[Bugfix] Ensure tensors are contiguous during serialisation #18860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2025
Merged

[Bugfix] Ensure tensors are contiguous during serialisation #18860

merged 2 commits into from
May 29, 2025

Conversation

@lgeiger
Copy link
Contributor

@lgeiger lgeiger commented May 28, 2025 •
edited by github-actions bot
Loading

This was removed in #18774 but breaks CI.

Sorry for missing this, I thought .flatten() would always return contiguous data.

@njhill Replaces #18857

@github-actions
Copy link

github-actions bot commented May 28, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 28, 2025
@lgeiger lgeiger mentioned this pull request May 28, 2025
Merged
@ekagra-ranjan ekagra-ranjan mentioned this pull request May 28, 2025
Merged
njhill
njhill reviewed May 28, 2025
View reviewed changes
@njhill
Copy link
Member

njhill commented May 29, 2025

Thanks @lgeiger, will make sure to run the MM CI tests on this.

@njhill njhill mentioned this pull request May 29, 2025
Closed
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label May 29, 2025
njhill
njhill approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lgeiger

@vllm-bot vllm-bot merged commit 0b1447f into vllm-project:main May 29, 2025
72 of 74 checks passed
@lgeiger lgeiger deleted the fix-serialisation branch May 29, 2025 10:08
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@lgeiger @amitm02
[Bugfix] Ensure tensors are contiguous during serialisation (vllm-pro…
d1302ed 
…ject#18860)

Signed-off-by: Lukas Geiger <[email protected]>
Signed-off-by: amit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njhill njhill njhill approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lgeiger @njhill @vllm-bot