Skip to content

Conversation

@mickaelseznec
Copy link
Contributor

@mickaelseznec mickaelseznec commented Jun 3, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results

Purpose

Fix #15435

Test Plan

CUDA 12.6 isn't used as default but might still be useful for some people. Not sure we want to add a CI check to this? I've tested locally, but if you want more testing, let me know what I should do 🙂

Test Result

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jun 3, 2025
@mickaelseznec mickaelseznec force-pushed the mseznec/patch-cuda-12-6-install branch 2 times, most recently from 5666007 to 88d99cf Compare June 3, 2025 16:55
@houseroad
Copy link
Collaborator

@huydhn , could you help review this one?

setup.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we can move most of the changes to some file like setup_utils.py, and only keep the call / override logic here to minimize the changes in the setup.py.

Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we can move most of the changes to some file like setup_utils.py, and only keep the call / override logic here to minimize the changes in the setup.py.

agreed; it'll be a bit easier to remove if this ever gets fixed

Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@LucasWilkinson LucasWilkinson enabled auto-merge (squash) August 1, 2025 14:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 1, 2025
Signed-off-by: Mickael Seznec <[email protected]>
Signed-off-by: Mickael Seznec <[email protected]>
Signed-off-by: Mickael Seznec <[email protected]>
Signed-off-by: Mickael Seznec <[email protected]>
@LucasWilkinson LucasWilkinson force-pushed the mseznec/patch-cuda-12-6-install branch from a40bf44 to 7fbb98e Compare August 17, 2025 19:00
Signed-off-by: Lucas Wilkinson <[email protected]>
@mergify
Copy link

mergify bot commented Sep 8, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mickaelseznec.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build needs-rebase ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Installation]: Fail to build vLLM from source on CUDA 12.6

3 participants