Skip to content

Conversation

@yaochengji
Copy link
Collaborator

@yaochengji yaochengji commented Jun 6, 2025

Purpose

Use self.kv_cache_dtype instead of attn_module.dtype in tpu model runner, introduced by #14570

Test Plan

python examples/offline_inference/tpu.py

Test Result

No error.

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@yaochengji yaochengji requested a review from heheda12345 June 6, 2025 03:10
@mergify mergify bot added v1 tpu Related to Google TPUs labels Jun 6, 2025
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@heheda12345 heheda12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heheda12345 heheda12345 added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 6, 2025
@DarkLight1337 DarkLight1337 merged commit 0d49483 into vllm-project:main Jun 6, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants