Skip to content

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Jun 10, 2025

Purpose

Since #14864 MultiModalHasher.hash_prompt_mm_data isn't used anymore. This PR removes the implementation as it's not necessary anymore.

Test Plan

Covered by unittests

Test Result

See CI

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @lgeiger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code cleanup by removing a method (hash_prompt_mm_data) within the MultiModalHasher class that was identified as unused after a previous refactoring (PR #14864). This simplifies the codebase by eliminating dead code and associated imports.

Highlights

  • Code Removal: Removed the hash_prompt_mm_data method from MultiModalHasher as it is no longer used following changes in PR #14864.
  • Cleanup: Removed unused imports (Optional, TYPE_CHECKING, TokensPrompt) that were only required by the removed method.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Jun 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the MultiModalHasher.hash_prompt_mm_data method and its associated unused imports (Optional from typing, and TokensPrompt under TYPE_CHECKING). The changes are clean and directly reflect the stated purpose of removing unused code.

Assuming the hash_prompt_mm_data method is indeed unused as stated in the pull request description (following #14864), these changes are a good cleanup step for maintainability. The type alias MultiModalHashDict, which was the return type of the removed function, is correctly retained as it appears to be used elsewhere in the codebase (e.g., in vllm/multimodal/inputs.py).

The PR description mentions that this is covered by unit tests, which is good. Overall, the changes look straightforward and beneficial.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 11, 2025 02:12
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 11, 2025
@DarkLight1337 DarkLight1337 merged commit 96ada38 into vllm-project:main Jun 11, 2025
75 checks passed
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@lgeiger lgeiger deleted the cleanup-hasher branch June 11, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants