Skip to content

Conversation

@noiji
Copy link
Contributor

@noiji noiji commented Jun 13, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Fixes #15784

Test Plan

add the following to the quantization_config field of config.json

"quant_method": "fp8",
"activation_scheme": "static",

and then serve with

vllm serve {modelopt_quantized_model}

Test Result

(AS-IS)

ERROR 06-13 14:37:58 [core.py:515]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/models/qwen3_moe.py", line 535, in load_weights
ERROR 06-13 14:37:58 [core.py:515]     return loader.load_weights(weights)
ERROR 06-13 14:37:58 [core.py:515]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 06-13 14:37:58 [core.py:515]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/models/utils.py", line 278, in load_weights
ERROR 06-13 14:37:58 [core.py:515]     autoloaded_weights = set(self._load_module("", self.module, weights))
ERROR 06-13 14:37:58 [core.py:515]                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 06-13 14:37:58 [core.py:515]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/models/utils.py", line 236, in _load_module
ERROR 06-13 14:37:58 [core.py:515]     yield from self._load_module(prefix,
ERROR 06-13 14:37:58 [core.py:515]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/models/utils.py", line 209, in _load_module
ERROR 06-13 14:37:58 [core.py:515]     loaded_params = module_load_weights(weights)
ERROR 06-13 14:37:58 [core.py:515]                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 06-13 14:37:58 [core.py:515]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/models/qwen3_moe.py", line 469, in load_weights
ERROR 06-13 14:37:58 [core.py:515]     param = params_dict[name]
ERROR 06-13 14:37:58 [core.py:515]             ~~~~~~~~~~~^^^^^^
ERROR 06-13 14:37:58 [core.py:515] KeyError: 'layers.40.self_attn.qkqkv_proj.k_scale'

(TO-BE)

  • loads the model successfully

(Optional) Documentation Update

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@noiji noiji changed the title Skip loading extra bias for modelopt models Skip loading extra parameters for modelopt models Jun 13, 2025
@noiji noiji changed the title Skip loading extra parameters for modelopt models Skip loading extra parameters for modelopt Qwen3 MoE model Jun 13, 2025
@noiji noiji marked this pull request as ready for review June 13, 2025 06:43
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you list the test plan and test results?

@noiji
Copy link
Contributor Author

noiji commented Jun 13, 2025

Could you list the test plan and test results?

added it. thx @houseroad

@noiji noiji changed the title Skip loading extra parameters for modelopt Qwen3 MoE model [Bugfix] Skip loading extra parameters for modelopt Qwen3 MoE model Jun 13, 2025
Copy link
Collaborator

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix.

It will be good to add some unittest. (Feel free to do so in the following PR.)

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 15, 2025
noiji added 4 commits June 18, 2025 12:40
Signed-off-by: noiji <>
Signed-off-by: noiji <>
Signed-off-by: noiji <>
@noiji
Copy link
Contributor Author

noiji commented Jun 18, 2025

It will be good to add some unittest. (Feel free to do so in the following PR.)

Will do in a follow-up PR. Thanks for the suggestion! @houseroad

@mergify mergify bot added the qwen Related to Qwen models label Jun 18, 2025
@noiji
Copy link
Contributor Author

noiji commented Jun 30, 2025

Hi @houseroad @NickLucche all checks passed and PR is ready — could you help with the merge? Thanks!

@houseroad houseroad merged commit f5dfa07 into vllm-project:main Jun 30, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Failed to load modelopt quantized fp8 model

3 participants