-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Bugfix] Skip loading extra parameters for modelopt Qwen3 MoE model #19598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
houseroad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you list the test plan and test results?
added it. thx @houseroad |
NickLucche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
houseroad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the fix.
It will be good to add some unittest. (Feel free to do so in the following PR.)
Signed-off-by: noiji <>
Signed-off-by: noiji <>
Signed-off-by: noiji <>
Signed-off-by: noiji <>
Will do in a follow-up PR. Thanks for the suggestion! @houseroad |
|
Hi @houseroad @NickLucche all checks passed and PR is ready — could you help with the merge? Thanks! |
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Fixes #15784
Test Plan
add the following to the
quantization_configfield of config.jsonand then serve with
Test Result
(AS-IS)
(TO-BE)
(Optional) Documentation Update