Skip to content

Conversation

andyxning
Copy link
Contributor

@andyxning andyxning commented Jun 19, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Fix pre-commit fail about qwen2_5 files in #19812.
image

Test Plan

NA

Test Result

NA

(Optional) Documentation Update

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @andyxning, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves pre-commit formatting issues identified in files related to the qwen2_5 models. The changes are purely cosmetic, ensuring code adherence to established style guidelines without altering functionality.

Highlights

  • Code Formatting: Addressed pre-commit failures by reformatting the image_processor arguments within get_hf_processor calls in vllm/model_executor/models/qwen2_5_omni_thinker.py and vllm/model_executor/models/qwen2_5_vl.py. This involved changing multi-line arguments to single-line for style compliance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the qwen Related to Qwen models label Jun 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a pre-commit failure by reformatting long lines in two Python files (vllm/model_executor/models/qwen2_5_omni_thinker.py and vllm/model_executor/models/qwen2_5_vl.py). The changes are purely stylistic and appear to be the result of running an automated formatter, likely black, as indicated by the PR description.

The new formatting for the image_processor argument within the get_hf_processor method calls in both files is consistent with standard Python formatting practices (PEP 8, as typically enforced and augmented by black) for handling long lines and nested function arguments. These changes improve code consistency by ensuring adherence to the project's linting rules.

No issues of medium, high, or critical severity were found. The changes are approved from a code quality and clarity perspective.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee
Copy link
Collaborator

Similar to: #19826

@andyxning andyxning force-pushed the fix_pre-commit_fail_about_qwen2_5 branch from f9c561c to 24491fe Compare June 19, 2025 03:57
@DarkLight1337
Copy link
Member

DarkLight1337 commented Jun 19, 2025

Closing as superseded by #19826

@andyxning andyxning deleted the fix_pre-commit_fail_about_qwen2_5 branch June 19, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants