-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[Misc] fix pre-commit fail about qwen2_5 #19834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] fix pre-commit fail about qwen2_5 #19834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @andyxning, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves pre-commit formatting issues identified in files related to the qwen2_5
models. The changes are purely cosmetic, ensuring code adherence to established style guidelines without altering functionality.
Highlights
- Code Formatting: Addressed pre-commit failures by reformatting the
image_processor
arguments withinget_hf_processor
calls invllm/model_executor/models/qwen2_5_omni_thinker.py
andvllm/model_executor/models/qwen2_5_vl.py
. This involved changing multi-line arguments to single-line for style compliance.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a pre-commit failure by reformatting long lines in two Python files (vllm/model_executor/models/qwen2_5_omni_thinker.py
and vllm/model_executor/models/qwen2_5_vl.py
). The changes are purely stylistic and appear to be the result of running an automated formatter, likely black
, as indicated by the PR description.
The new formatting for the image_processor
argument within the get_hf_processor
method calls in both files is consistent with standard Python formatting practices (PEP 8, as typically enforced and augmented by black
) for handling long lines and nested function arguments. These changes improve code consistency by ensuring adherence to the project's linting rules.
No issues of medium
, high
, or critical
severity were found. The changes are approved from a code quality and clarity perspective.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Similar to: #19826 |
Signed-off-by: Andy Xie <[email protected]>
f9c561c
to
24491fe
Compare
Closing as superseded by #19826 |
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Fix pre-commit fail about qwen2_5 files in #19812.

Test Plan
NA
Test Result
NA
(Optional) Documentation Update